Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklist GCMajor tracing markers #348

Closed
mstange opened this issue May 23, 2017 · 3 comments
Closed

Blacklist GCMajor tracing markers #348

mstange opened this issue May 23, 2017 · 3 comments
Labels
markers Anything to do with marker data structures, marker chart, or the marker table

Comments

@mstange
Copy link
Contributor

mstange commented May 23, 2017

We already blacklist DOMEvent markers for similar reasons.
@hotsphink
Copy link
Contributor

Details: GCMajor covers the whole span of an incremental GC, during which time the browser is running, periodically interrupted with GC slices. The total duration of the major GC isn't terribly relevant, and obscures all of the things happening during that period. Just showing GC slices is good enough to see when and where the GC is doing work.

@gregtatum gregtatum added the markers Anything to do with marker data structures, marker chart, or the marker table label May 26, 2017
@gregtatum
Copy link
Member

Are you looking at markers in the header, or the timeline view?

@hotsphink
Copy link
Contributor

In the header. The timeline view of these is very nice, I do not want it blacklisted from there!

@julienw julienw mentioned this issue Jun 8, 2017
Closed
julienw added a commit to julienw/perf.html that referenced this issue Jul 5, 2017
@julienw
Filter GCMajor markers out from the overview (Fixes: firefox-devtools…
517251a 
…#348)
julienw added a commit to julienw/perf.html that referenced this issue Jul 6, 2017
@julienw
Filter GCMajor markers out from the overview (Fixes: firefox-devtools…
23d463e 
…#348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
markers Anything to do with marker data structures, marker chart, or the marker table
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hotsphink @mstange @gregtatum